Repository navigation
Specify RBS requirement during export command - #813
Merged
Merged
Conversation
KaanOzkan
force-pushed
the
ko/fix-export
branch
from
November 5, 2025 20:12
fb2cd21 to
e540ca9
Compare
KaanOzkan
changed the title
export cmdexport command
KaanOzkan
marked this pull request as ready for review
November 5, 2025 20:27
paracycle
approved these changes
Nov 5, 2025
Morriar
reviewed
Nov 7, 2025
| tapioca_context.write!("Gemfile", <<~RB) | ||
| source "https://rubygems.org" | ||
|
|
||
| gem "rbs", ">= 4.0.0.dev.4" |
Contributor
There was a problem hiding this comment.
@KaanOzkan Can you add a comment in https://github.com/Shopify/spoom/blob/main/spoom.gemspec#L37 so we don't forget to update this line when we finally bump RBS? 🙏
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the gem we run the
exportcommand with depends onrbiBundler pickstapiocav0.16.11 instead of the latest one. This now started erroring due to theT::Moduleerror with the latest sorbet-runtime.@paracycle pointed out that this is due to
rbsgem version being a pre-release. Current Spoom already depends on this pre-release version and we can just make that explicit in the Gemfile of theexportcommand. This way bundler will pick the correct tapioca version.